Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366790 - Allow to specify values from BundleImporterDelegate declaratively, in plugin.xml
Summary: Allow to specify values from BundleImporterDelegate declaratively, in plugin.xml
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-15 04:16 EST by Tomasz Zarna CLA
Modified: 2011-12-28 08:43 EST (History)
3 users (show)

See Also:

Attachments
Fix v01 (6.66 KB, patch)
2011-12-15 04:18 EST, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (6.17 KB, application/octet-stream)
2011-12-15 04:18 EST, Tomasz Zarna CLA 		no flags Details
Fix v02 (8.32 KB, patch)
2011-12-16 06:22 EST, Tomasz Zarna CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-12-15 04:16:35 EST 
See John's suggestion in bug 327381, comment 15.

In other words, remove "delegate" from bundleImporters extension point and replace it with additional attributes to specify supported SCM values and repository provider.
Comment 1 Tomasz Zarna CLA 2011-12-15 04:18:52 EST 
Created attachment 208425 [details]
Fix v01

The patch is not ready yet, it's missing doc for new attrs and a migration story if we decide we need one.
Comment 2 Tomasz Zarna CLA 2011-12-15 04:18:54 EST 
Created attachment 208426 [details]
mylyn/context/zip
Comment 3 Tomasz Zarna CLA 2011-12-16 06:22:28 EST 
Created attachment 208484 [details]
Fix v02

Better wording + doc update.
Comment 4 Tomasz Zarna CLA 2011-12-23 04:51:28 EST 
Fixed with 618e0c9e25740294600cbfeb5275d43229a53e44. Available in builds >= N20111223-2000.
Comment 5 Tomasz Zarna CLA 2011-12-28 08:33:16 EST 
Ouch, forgot to update the keys used in BundleImporterExtension between patch v01 and patch v02.
Comment 6 Tomasz Zarna CLA 2011-12-28 08:43:03 EST 
(In reply to comment #5)
> Ouch, forgot to update the keys used in BundleImporterExtension

Fixed with a89781cb00b6f709af8636b8d0eeba47be6ee10b.