Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366763 - PathMap service fixes for common usecases
Summary: PathMap service fixes for common usecases
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.6.0   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 17:26 EST by Peder Andersen CLA
Modified: 2013-06-05 06:18 EDT (History)
2 users (show)

See Also:

Attachments
Proposed changes for rootfs remap (1.27 KB, patch)
2011-12-14 17:26 EST, Peder Andersen CLA 		eugene: iplog+
Details | Diff
Proposed changes for identifier remap (1.53 KB, patch)
2011-12-14 17:27 EST, Peder Andersen CLA 		eugene: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peder Andersen CLA 2011-12-14 17:26:05 EST 
Created attachment 208412 [details]
Proposed changes for rootfs remap

Two usecases for the PathMap service don't work at the moment.
First, users have a complete copy of the target's rootfs accessible via a host path, so we effectively want to map "target:/" to "host:/path/to/rootfs".

Second, clients would like the ability to map a non-path identifier to an individual file, for example, to locate a target's kernel image (which typically does not reside on the target's filesystem).
Comment 1 Peder Andersen CLA 2011-12-14 17:27:00 EST 
Created attachment 208413 [details]
Proposed changes for identifier remap
Comment 2 Eugene Tarassov CLA 2011-12-15 14:45:22 EST 
I have committed the first patch. Thanks!

I don't understand second patch. It looks incorrect to me. It checks if strlen(src) == strlen(dst), but it looks like intention was to check strlen(src) == strlen(fnm), which is same as fnm[k] == 0, which is already properly handled without the patch.
Comment 3 Peder Andersen CLA 2011-12-15 15:11:27 EST 
You're right; I must have been confused between dst and fnm, *and* that the second patch generally seems unnecessary.  So far as I'm concerned, this bug is now fixed, thanks!
Comment 4 Eugene Tarassov CLA 2011-12-15 15:26:20 EST 
Changing to resolved/fixed.