Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366689 - Equinox SSH console missing in Target Components
Summary: Equinox SSH console missing in Target Components
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 08:24 EST by Gunnar Wagenknecht CLA
Modified: 2011-12-15 11:44 EST (History)
3 users (show)

See Also:


Attachments
org.eclipse.equinox.core.sdk feature patch (2.87 KB, patch)
2011-12-14 09:07 EST, Thomas Watson CLA
no flags Details | Diff
org.eclipse.equinox.core.sdk feature updated patch (2.89 KB, patch)
2011-12-14 10:59 EST, Thomas Watson CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gunnar Wagenknecht CLA 2011-12-14 08:24:31 EST
There is currently no way to conume the Equinox SSH Console. It's not available in the Equinox Target Components available in the 3.8milestones repo.
Comment 1 Thomas Watson CLA 2011-12-14 08:46:22 EST
The org.eclipse.equinox.core.sdk feature needs to include the following bundles:

org.eclipse.equinox.console.jaas.fragment
org.eclipse.equinox.console.ssh

And the orbit bundles:

org.apache.mina.core
org.apache.sshd.core

Lazar, are there any others required to get the ssh console functional?
Comment 2 Thomas Watson CLA 2011-12-14 09:07:54 EST
Created attachment 208380 [details]
org.eclipse.equinox.core.sdk feature patch

Kim, here is a patch to the org.eclipse.equinox.core.sdk feature.  I already updated the orbit.map to include source for the org.apache.mina.core and org.apache.sshd.core and I updated the core.map to include the org.eclipse.equinox.console.jaas.fragment and org.eclipse.equinox.console.ssh bundles in master.  Is there anything else needed?

Let me know when we can run a test build.
Comment 3 Lazar Kirchev CLA 2011-12-14 09:21:41 EST
(In reply to comment #1)
> The org.eclipse.equinox.core.sdk feature needs to include the following
> bundles:
> 
> org.eclipse.equinox.console.jaas.fragment
> org.eclipse.equinox.console.ssh
> 
> And the orbit bundles:
> 
> org.apache.mina.core
> org.apache.sshd.core
> 
> Lazar, are there any others required to get the ssh console functional?


In addition to these we need the logging bundles:

org.slf4j.api

and slf4j implementation; from orbit I think we can use - correct me if I am wrong - only the ch.cos.logback implementation, which includes the following bundles:

ch.qos.logback.slf4j
ch.qos.logback.core
ch.qos.logback.classic
Comment 4 Lazar Kirchev CLA 2011-12-14 09:27:10 EST
(In reply to comment #3)
> In addition to these we need the logging bundles:
> 
> org.slf4j.api
> 
> and slf4j implementation; from orbit I think we can use - correct me if I am
> wrong - only the ch.cos.logback implementation, which includes the following
> bundles:
> 
> ch.qos.logback.slf4j
> ch.qos.logback.core
> ch.qos.logback.classic

There are also other slf4j implementations in orbit, but the org.slf4j.api has Eclipse-GenericRequire: org.slf4j.impl.StaticLoggerBinder;selection-fi
 lter=(&(version>=1.6.0)(!(version>=1.7.0))), and this is provided only by the ch.qos.logback implementation.
Comment 5 Gunnar Wagenknecht CLA 2011-12-14 10:21:48 EST
(In reply to comment #4)
> There are also other slf4j implementations in orbit, but the org.slf4j.api has
> Eclipse-GenericRequire: org.slf4j.impl.StaticLoggerBinder;selection-fi
>  lter=(&(version>=1.6.0)(!(version>=1.7.0))), and this is provided only by the
> ch.qos.logback implementation.

I already have CQs open for submitting SLF4J 1.6.4 into Orbit. Those won't contain the requirement anymore.
Comment 6 Thomas Watson CLA 2011-12-14 10:59:21 EST
Created attachment 208387 [details]
org.eclipse.equinox.core.sdk feature updated patch

(In reply to comment #3)
> (In reply to comment #1)
> > The org.eclipse.equinox.core.sdk feature needs to include the following
> > bundles:
> > 
> > org.eclipse.equinox.console.jaas.fragment
> > org.eclipse.equinox.console.ssh
> > 
> > And the orbit bundles:
> > 
> > org.apache.mina.core
> > org.apache.sshd.core
> > 
> > Lazar, are there any others required to get the ssh console functional?
> 
> 
> In addition to these we need the logging bundles:
> 
> org.slf4j.api
> 
> and slf4j implementation; from orbit I think we can use - correct me if I am
> wrong - only the ch.cos.logback implementation, which includes the following
> bundles:
> 
> ch.qos.logback.slf4j
> ch.qos.logback.core
> ch.qos.logback.classic

Similar to what we did for bug 348075 we can compile using the org.eclipse.equinox.slf4j.stub that is included in the build time feature org.eclipse.sdk-feature/features/master-equinox/feature.xml.

I think we should do this for now instead of including the slf4j stuff in our features.  This just means clients will have to install their own slf4j implementation to use the ssh console support.

Kim, you can run a test build when convenient using the attached patch.  I needed to add fragment="true"
Comment 7 Kim Moir CLA 2011-12-15 11:29:54 EST
Can this bug be closed now or are we going to add the slf4j later?
Comment 8 Thomas Watson CLA 2011-12-15 11:44:17 EST
(In reply to comment #7)
> Can this bug be closed now or are we going to add the slf4j later?

Closing, I don't plan to add slf4j unless someone really thinks it must be added.