Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366682 - New File/Folder action not working from gear menu
Summary: New File/Folder action not working from gear menu
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 06:16 EST by Szymon Brandys CLA
Modified: 2011-12-14 12:30 EST (History)
3 users (show)

See Also:


Attachments
Screenshot for the problem (21.41 KB, image/png)
2011-12-14 06:18 EST, Szymon Brandys CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-12-14 06:16:52 EST
Steps:
1) Open File Navigator
2) Create a folder and try to create a file inside using Gear > New File

It fails and the console says:
node is null
http://localhost:8080/org.dojotoolkit/dojo/_base/html.js
Line 1167
Comment 1 Szymon Brandys CLA 2011-12-14 06:18:44 EST
Created attachment 208374 [details]
Screenshot for the problem
Comment 2 Szymon Brandys CLA 2011-12-14 06:19:03 EST
Gosia sees the same problem on her machine.
Comment 3 libing wang CLA 2011-12-14 09:04:58 EST
Saw the same issue here. But new file from tool bar is OK.
Comment 4 Susan McCourt CLA 2011-12-14 11:46:40 EST
you are seeing this from HEAD, right?  
Things seem to be fine on orion.eclipse.org

At first, I got the "node is null" problem but the creation of the new folder and file worked.
Then it stopped working completely. 
Working on a reproducible scenario....
Comment 5 Szymon Brandys CLA 2011-12-14 11:52:15 EST
(In reply to comment #4)
> you are seeing this from HEAD, right?  
Yes, HEAD.
Comment 6 Susan McCourt CLA 2011-12-14 12:30:57 EST
fixed with 2c4222bbccd4f5f8480475ab796bb78e4f09e5a3.

The span containing the gear menu had no id and the parameter popup couldn't find where to put itself.  I fixed the bug but also added some console warnings in the command service to flag this condition.  (Did not throw an exception because clients can get away without having an id until they need a tooltip dialog popup off a menu.  At that point, the id is used to locate the position of the popup).