Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366648 - Fix to make toolbars dissappear and appear per UniversalEditor instance
Summary: Fix to make toolbars dissappear and appear per UniversalEditor instance
Status: RESOLVED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: IMP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Robert M. Fuhrer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-13 18:06 EST by Jurgen Vinju CLA
Modified: 2014-01-09 15:03 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jurgen Vinju CLA 2011-12-13 18:06:35 EST 
This patch finally makes the language contribution extension point complete. It now manages to manage the toolbar items properly, such that each instance of ILanguageContributor can actually be connected to a particular editor with a particular input (for different languages and for different files in the same language). 

This required some intricate use of IPartListener2 API in UniversalEditor. 

I'm submitting it as a patch for careful review. I think it is an important enhancement for the IMP run-time since toolbar items are such a good way to design interaction with the user but we never had it readily available to the IDE developer.
Comment 1 Jurgen Vinju CLA 2012-02-02 10:45:12 EST 
Alas. it is broken :-( This particular issue is nagging me bigtime. It is some intricate problem with the way the platform expects toolbars to be connected to editor-id's that just does not fly well with UniversalEditor. I'm ready to make a new GUI element at the top of UniversalEditor to host buttons, just to avoid this entire issue. ToolBars are nice to have; I think even essential for usability.