Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366628 - [Generation] Logging an INFO message to generation dialog will mark generation as failed
Summary: [Generation] Logging an INFO message to generation dialog will mark generatio...
Status: CLOSED FIXED
Alias: None
Product: Tigerstripe
Classification: Technology
Component: Plugin (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 0.5M0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-13 16:01 EST by Navid Mehregani CLA
Modified: 2012-01-04 17:04 EST (History)
1 user (show)

See Also:

Attachments
Generation dialog (41.31 KB, image/png)
2011-12-13 16:02 EST, Navid Mehregani CLA 		no flags Details
Generator used (12.77 KB, application/octet-stream)
2011-12-13 16:02 EST, Navid Mehregani CLA 		no flags Details
Patch (951 bytes, patch)
2011-12-20 03:04 EST, Alena Repina CLA 		no flags Details | Diff
Patch containing a Q7 test for this case (30.15 KB, patch)
2011-12-20 03:15 EST, Alena Repina CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Navid Mehregani CLA 2011-12-13 16:01:41 EST 
Build Identifier: 

Using the PluginLog.reportStatus(...) API to log an Info message will mark generation as "Failed"!  See attached snapshot for more details.

I've also attached the generator used.  Notice line#119 on MyRunnableRule:
		PluginLog.reportStatus(new Status(IStatus.INFO, "pluginID", "my message."));

This shouldn't cause generation to fail

Reproducible: Always
Comment 1 Navid Mehregani CLA 2011-12-13 16:02:01 EST 
Created attachment 208346 [details]
Generation dialog
Comment 2 Navid Mehregani CLA 2011-12-13 16:02:57 EST 
Created attachment 208347 [details]
Generator used
Comment 3 Alena Repina CLA 2011-12-20 03:04:30 EST 
Created attachment 208591 [details]
Patch

Navid, I've fixed the bug and attached a patch.
Comment 4 Alena Repina CLA 2011-12-20 03:15:09 EST 
Created attachment 208592 [details]
Patch containing a Q7 test for this case

Navid, I've also created a Q7 test for such a case and attached it in the testPatch.txt
Comment 5 Valentin Yerastov CLA 2011-12-20 06:37:32 EST 
patch has been applied
Comment 6 Navid Mehregani CLA 2012-01-04 17:04:35 EST 
Looks good. Thanks!