Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366560 - Command#isHandled() always returns true
Summary: Command#isHandled() always returns true
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks: 366554
  Show dependency tree
 
Reported: 2011-12-13 10:46 EST by Paul Webster CLA
Modified: 2019-12-10 15:20 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2011-12-13 10:46:42 EST 
org.eclipse.ui.internal.MakeHandlersGo doesn't re-implement isHandled() to query if a command is handled.  This causes failures:

org.eclipse.ui.tests.commands.Bug74990Test.testPartIdSubmission()
org.eclipse.ui.tests.commands.HandlerActivationTest.testBasicHandler()
org.eclipse.ui.tests.commands.HandlerActivationTest.testForBreak123()
... break tests
org.eclipse.ui.tests.commands.HandlerActivationTest.testTwoHandlers()
org.eclipse.ui.tests.commands.CommandEnablementTest.testEnablementForNormalHandlers()
org.eclipse.ui.tests.commands.CommandEnablementTest.testEventsForNormalHandlers()
org.eclipse.ui.tests.commands.CommandEnablementTest.testEventsForDisabledHandlers()
org.eclipse.ui.tests.commands.CommandEnablementTest.testEventsForEnabledHandlers()
org.eclipse.ui.tests.commands.CommandEnablementTest.testEnablementForLocalContext()

org.eclipse.ui.tests.commands.ActionDelegateProxyTest.testEditorActionDelegate()
Comment 1 Paul Webster CLA 2011-12-15 14:54:12 EST 
Tackled the first round of tests effected by isHandled().

Updated some tests and some MakeHandlersGo support.

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=40bd0d14c317387709393df8d4e4c6ce2ef15ba4

PW
Comment 3 Paul Webster CLA 2011-12-16 14:08:06 EST 
(In reply to comment #2)
> Down to 32 failures with

That's down to 23 failures from 34
Comment 4 Remy Suen CLA 2012-03-08 09:01:52 EST 
(In reply to comment #0)
> org.eclipse.ui.tests.commands.HandlerActivationTest.testTwoHandlers()

Fixed in master.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7c1027af3a7a17e0e74d51a7b7d7ff0579b70d83
Comment 5 Lars Vogel CLA 2019-11-14 03:22:39 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.
Comment 6 Rolf Theunissen CLA 2019-12-10 15:20:24 EST 
Closed as per Comment 4