Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366510 - Plug-in list page does not use the command framework
Summary: Plug-in list page does not use the command framework
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 RC1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 370588
  Show dependency tree
 
Reported: 2011-12-13 05:18 EST by Szymon Brandys CLA
Modified: 2012-02-09 19:54 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-12-13 05:18:52 EST 
/plugin/list.html does not use the command framework for "Install", "Uninstall" at other commands. They are just added as links and then linked using dojo.connect(button, "onclick", function(){...}) to the code performing the operation. Also the selection mechanism is different than on other pages where we use checkboxes.

I noticed that Anton works on the Orion preference page that also shows the plug-ins data. This new page seems to follow the incorrect pattern used on the plug-in list page.
Comment 1 Szymon Brandys CLA 2011-12-13 05:26:26 EST 
As I understand the plug-in list page will be removed soon and replaced by the new preferences page.  So let's treat this bug as against the new page.
Comment 2 Susan McCourt CLA 2011-12-13 11:26:16 EST 
I think the main thing is to ensure that the page architecture (where you look for commands, modal slideout/fold down, etc.) ends up consistent with the rest of the pages by the time we ship 0.4.  I kind of like seeing the alternate folddown while he is experimenting, it might give us ideas for improving the horizontal slideout.  Another factor is that we'll do a round with Linda on page anatomy so that we have a better architecture for where various commands go.
Comment 3 Susan McCourt CLA 2012-01-22 16:13:06 EST 
The new anatomy/header is released as is Anton's page.  Looking at everything together now, I think what needs to happen is:

- the "install" command should be a "dom" level command contributed by the plugins section of the settings page.  It should be contributed to "pageActions" which will cause it to appear in the toolbar above, and it should specify a required URL parameter (see the git clone command in gitcommands.js as an example).  This will cause the parameter slideout to appear with the workflow used elsewhere (and will remove the need for the "hide" button that is there now).

- an additional command "reload all" should be added to the toolbar

- the remove buttons should be "object" level commands and instead of putting buttons in the html, the command framework should render object level commands in there.

This way, the slideout and toolbar will behave like it does everywhere else.  The way we render buttons in actions columns is still to be mocked up by the graphic designer so the look of the "object" contribution will evolve too.
Comment 4 Susan McCourt CLA 2012-01-25 14:17:22 EST 
I told Anton I'd take this one, will be easier for him to learn by browsing the diffs.  Probably in RC1.