Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366498 - [preferences][breadcrumb] Show editor breadcrumb and hide package element in outline view by default
Summary: [preferences][breadcrumb] Show editor breadcrumb and hide package element in ...
Status: RESOLVED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.8   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 3.8   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-13 02:58 EST by Andrey Loskutov CLA
Modified: 2012-03-29 05:38 EDT (History)
3 users (show)

See Also:


Attachments
Patch (1.61 KB, patch)
2012-03-29 05:38 EDT, Dani Megert CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2011-12-13 02:58:09 EST
Build Identifier: 3.8

This is a follow-up of the bug 366329.

The initial request was to hide "package/imports" elements shown in the outline view, as this elements are never used for navigation and so just wasting the place in the outline.

On the other side, Dani argued that the "package" element in outline is shown by default because it is kind of a visual marker to show where the class is located.

To cleanup the use model, here is the proposal:

Java editor already has a "visual" hint to show where the class is located: this is the breadcrumb on the top. So if it would be visible by default, we can hide the packages node in outline view by default.

As the Java editor breadcrumb is very useful anyway (and packages node in outline is not), it just makes sense to clean the things up here.

Reproducible: Always
Comment 1 Dani Megert CLA 2012-03-22 11:16:46 EDT
The breadcrumb can be enabled by perspective because it is not equally useful in every perspective. On the other hand, the filters are per workbench. If we disable the package declaration filter, then that information would be lost in perspectives that don't show the breadcrumb. In addition, the breadcrumb is not available in the Java compare editor. Besides that, changing the defaults at this point would "destroy" nicely setup perspectives in existing workbenches. For those reasons we decided not to fix this bug.

We also discussed to connect the filter options with the breadcrumb visibility and maybe also the 'Link with Editor' state but decided that this would be to complicated for users to understand.
Comment 2 Dani Megert CLA 2012-03-29 05:38:14 EDT
Created attachment 213324 [details]
Patch

Code which I used to experiment with the feature.