Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366449 - [Compatibility] No hook for event idle loop yet
Summary: [Compatibility] No hook for event idle loop yet
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: 4.2 M5   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 366451 381873
  Show dependency tree
 
Reported: 2011-12-12 14:22 EST by Paul Webster CLA
Modified: 2012-06-06 11:11 EDT (History)
3 users (show)

See Also:

Attachments
Allow event idle advisor v01 (7.32 KB, patch)
2011-12-14 14:52 EST, Paul Webster CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2011-12-12 14:22:51 EST 
org.eclipse.ui.parts.tests.PartsReferencesTestSuite depends on implementing org.eclipse.ui.application.WorkbenchAdvisor.eventLoopIdle(Display) but in Eclipse 4, we have no hook for the event idle loop yet.

Without this, all of its tests hang.

PW
Comment 1 Paul Webster CLA 2011-12-14 14:52:00 EST 
Created attachment 208401 [details]
Allow event idle advisor v01

The part rendering engine takes "advice" from the IEventLoopAdvisor.

PW
Comment 2 Paul Webster CLA 2011-12-15 09:56:44 EST 
This patches allows PartsReferencesTestSuite to finish.  It takes 2626 seconds to run.

This is compared to 26 seconds.

PW
Comment 3 Paul Webster CLA 2011-12-15 12:09:39 EST 
Switched around the runOnce variable and released.

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=086d5af83b661709b371be311e75f2cc341a6c56

PW
Comment 4 Paul Webster CLA 2012-01-24 13:47:39 EST 
In I20120123-2200
PW