Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366447 - [commands] consider using context menus instead of dropdown button when menu group is textless
Summary: [commands] consider using context menus instead of dropdown button when menu ...
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 RC1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-12 13:51 EST by Susan McCourt CLA
Modified: 2012-02-21 12:18 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-12-12 13:51:28 EST
When a group of menu commands has no text, we want to use a button/gear menu to invoke the menu.  At this point, the button is really behaving as a context menu trigger.  There's no reason for us to use dijit.DropDownButton in these cases because we're not trying to position the menu directly under the invoking button.  It would simplify the code (and styling!) if we instead create our normal command span with an image and just bring up a context menu when it's clicked.
Comment 1 Susan McCourt CLA 2011-12-14 13:55:13 EST
The down side of dropping DropDownButton is that it provides free tab traversal and activation on the space key.  I should probably try harder at styling it appropriately.  What I want is the same look as image commands, with a border and hover shading.
Comment 2 Susan McCourt CLA 2012-02-21 12:18:59 EST
we fixed the icon, styling, hover effect in RC1.
No need to change the implementation.