Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366364 - DS-Check in E4Application is meaningless
Summary: DS-Check in E4Application is meaningless
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard: candidate43
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-12 04:27 EST by Thomas Schindl CLA
Modified: 2014-09-08 13:37 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2011-12-12 04:27:54 EST 
The check we are running in E4Application to see if DS is running makes no sense anymore with the changes made in commit 0d6cd94911dcb221379022563d11ed7f4c71ff91 in bug 351366 because the EModelService is not coming anymore from DS but is created in createDefaultContext()
Comment 1 Eric Moffatt CLA 2012-02-08 16:33:54 EST 
Tom, nice pickup !

Perhaps we should switch over to checking against the EPartService instead (I believe it's contributed through DS isn't it ?
Comment 2 Eric Moffatt CLA 2012-02-09 13:49:35 EST 
I've modified the check to test against the EPartService instead, it is still contributed as a dynamic service...
Comment 3 Eric Moffatt CLA 2012-03-13 11:30:41 EDT 
Verified (visually) in I20120312-1730.
Comment 4 Brian de Alwis CLA 2012-05-09 12:43:18 EDT 
As per bug 378975, the change made doesn't actually catch the problem as the check now occurs after the call to getDefaultContext(), and so after the attempt to install EModelService into the context fails.
Comment 5 John Arthorne CLA 2012-06-06 11:30:59 EDT 
Eric please update the milestone to something in the future.
Comment 6 Lars Vogel CLA 2014-01-23 10:19:16 EST 
I think with Bug 379023 implemented we can remove this check.
Comment 7 Lars Vogel CLA 2014-01-23 10:21:41 EST 
https://git.eclipse.org/r/20999
Comment 9 Lars Vogel CLA 2014-09-08 11:20:33 EDT 
If the branding plug-in is null this argument is still not set. To test remove the "product" field in the product editor.
Comment 10 Lars Vogel CLA 2014-09-08 11:26:03 EDT 
https://git.eclipse.org/r/33055