Community
Participate
Working Groups
Build Identifier: Virgo3.0.2 Attached are updates made to the bin/start.sh, bin/shutdown.sh, bin/dmk.sh and bin/checkJava.sh that correctly allow scripts to run under cygwin (www.cygwin.com) bash shell. Reproducible: Always Steps to Reproduce: N/A
Created attachment 208240 [details] contents of bin directory with updated scripts for cygwin support
Can you please confirm that you wrote 100% of the code and you have the right to contribute it to Eclipse?
(In reply to comment #2) > Can you please confirm that you wrote 100% of the code and you have the right > to contribute it to Eclipse? Hi Hristo, I myself did the updates to the few scripts in the attached "bin.zip" file. I am not currently a contributor to Eclipse. The attached "bin.zip" is mainly a suggestion of what I did to make the scripts work under cygwin. They are completely backward compatible. My thought is that a current contributor would evaluate what I did to the scripts and then decide if they want to apply the updates to the master build. This would allow future versions of Virgo to run under cygwin shells without any modifications. Thx, Scott Brand
(In reply to comment #3) > (In reply to comment #2) > > Can you please confirm that you wrote 100% of the code and you have the right > > to contribute it to Eclipse? > > Hi Hristo, > I myself did the updates to the few scripts in the attached "bin.zip" file. > I am not currently a contributor to Eclipse. > The attached "bin.zip" is mainly a suggestion of what I did to make the scripts > work under cygwin. They are completely backward compatible. > My thought is that a current contributor would evaluate what I did to the > scripts and then decide if they want to apply the updates to the master build. > This would allow future versions of Virgo to run under cygwin shells without > any modifications. > > Thx, > Scott Brand Hi Scott You are absolutely correct about the way your suggestion should be processed. However, we would like to take your changes as a starting point rather than re-invent them. In Eclipse terminology this would make you a contributor. The intellectual property rules of Eclipse require committers to check three things for every contribution: 1. New Java files must have the appropriate license header. 2. The contributor must have authored 100% of the changes they are contributing. 3. The contributor must have the rights to make the contribution. This is usually a matter of the contributor's employer allowing the contributor to make the contribution. For example, some employers assert ownership of all code produced by their employees and in such cases, the employer needs to agree to their code being contributed to Eclipse.org. Since there are no Java files in this contribution, #1 does not apply. You've already stated that you did the updates to the scripts yourself, so #2 is complete. We would be very grateful, therefore, if you could confirm #3: that you have your employer's permission to make the contribution.
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Can you please confirm that you wrote 100% of the code and you have the right > > > to contribute it to Eclipse? > > > > Hi Hristo, > > I myself did the updates to the few scripts in the attached "bin.zip" file. > > I am not currently a contributor to Eclipse. > > The attached "bin.zip" is mainly a suggestion of what I did to make the scripts > > work under cygwin. They are completely backward compatible. > > My thought is that a current contributor would evaluate what I did to the > > scripts and then decide if they want to apply the updates to the master build. > > This would allow future versions of Virgo to run under cygwin shells without > > any modifications. > > > > Thx, > > Scott Brand > > Hi Scott > > You are absolutely correct about the way your suggestion should be processed. > However, we would like to take your changes as a starting point rather than > re-invent them. In Eclipse terminology this would make you a contributor. The > intellectual property rules of Eclipse require committers to check three things > for every contribution: > > 1. New Java files must have the appropriate license header. > 2. The contributor must have authored 100% of the changes they are > contributing. > 3. The contributor must have the rights to make the contribution. This is > usually a matter of the contributor's employer allowing the contributor to make > the contribution. For example, some employers assert ownership of all code > produced by their employees and in such cases, the employer needs to agree to > their code being contributed to Eclipse.org. > > Since there are no Java files in this contribution, #1 does not apply. > > You've already stated that you did the updates to the scripts yourself, so #2 > is complete. > > We would be very grateful, therefore, if you could confirm #3: that you have > your employer's permission to make the contribution. Hi Glyn, Thank you for your prompt response, and at some point I suspect I may become a contributor to Virgo. For now at least, I can confirm that I did these script updates off hours, or in otherwords, on my own time and outside the control of my employer, so the contribution is wholly my own. Hope that helps, Scott
Thanks Scott! As soon as we've included the changes you made, you will be a contributor - you don't need to do anything else. :-)
Commit 006e113f9ec35c00be0ea65aac1742cdc29b6261 adds support for Cygwin in *.sh scripts. Thanks for the contribution :)
