366318 – tycho unconditionally downloads native launchers during rcp application build

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366318 - tycho unconditionally downloads native launchers during rcp application build

Summary: tycho unconditionally downloads native launchers during rcp application build

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Tycho (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Igor Fedorenko
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-12-11 00:34 EST by Igor Fedorenko
Modified:	2021-04-28 16:54 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
patch (6.37 KB, patch) 2011-12-12 04:11 EST, Jan Sievers	no flags	Details \| Diff
patch v2 (7.15 KB, patch) 2011-12-12 04:45 EST, Jan Sievers	no flags	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Igor Fedorenko

2011-12-11 00:34:44 EST

Download of native launchers during RCP application build is not needed when includeLaunchers="false" in .product file. Doing so is both unnecessary slowing down the build and actually makes the build fail when native launchers are not available. The latter makes tycho unusable for Eclipse 4.2 Juno M4 due to bug 355433.

Comment 1 Igor Fedorenko

2011-12-11 09:05:43 EST

Fixed both in current master and backported to 0.13.1

master 
http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=2310a0a2f89d299f6925fa5f9dc9e9c5743e1fde

0.13.1 
https://github.com/sonatype/sonatype-tycho/commit/d0e1738af2d8fc1def9583d3c3b3ac398b092c59
https://github.com/sonatype/sonatype-tycho/commit/7ceaaf694afd221aa8e7b63bdd1ec88082341884

Comment 2 Jan Sievers

2011-12-12 04:11:22 EST

Created attachment 208244 [details]
patch

alternatively, does attached patch work around the problem?

Then we wouldn't need a 0.13.1 release

Comment 3 Jan Sievers

2011-12-12 04:45:51 EST

Created attachment 208246 [details]
patch v2

Comment 4 Jan Sievers

2011-12-12 05:53:22 EST

(In reply to comment #3)
Ignore my last two comments.

With commit http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=b1534b38c3514c930b9547bbddfcc5b4fdd36eaa

there is no need for 0.13.1 anymore and I don't think the severity for users is high enough to require a patch release.