Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366317 - jgit log crashes in the presence of notes when no argument are passed
Summary: jgit log crashes in the presence of notes when no argument are passed
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 1.2   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 2.1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-10 18:53 EST by Robin Rosenberg CLA
Modified: 2013-04-19 04:44 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Rosenberg CLA 2011-12-10 18:53:35 EST 
$ jgit log
java.lang.NullPointerException
	at org.eclipse.jgit.pgm.Log.addNoteMap(Log.java:227)
	at org.eclipse.jgit.pgm.Log.run(Log.java:201)
	at org.eclipse.jgit.pgm.TextBuiltin.execute(TextBuiltin.java:148)
	at org.eclipse.jgit.pgm.Main.execute(Main.java:191)
	at org.eclipse.jgit.pgm.Main.run(Main.java:120)
	at org.eclipse.jgit.pgm.Main.main(Main.java:94)

Bisect points to 489604aaad8ef8d252bf31056db4de01e690fa0b

$ jgit log HEAD # does not crash

A reason may be that there are too many "walks" in the code, leading to confusion
about which one to use and when.
Comment 1 Robin Rosenberg CLA 2013-04-19 04:44:12 EDT 
Was fixed in 2.1
Comment 2 Robin Rosenberg CLA 2013-04-19 04:44:29 EDT 
.