Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366243 - JGit ignores error on stdout
Summary: JGit ignores error on stdout
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 369461
  Show dependency tree
 
Reported: 2011-12-09 14:37 EST by Robin Rosenberg CLA
Modified: 2013-02-08 01:49 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Rosenberg CLA 2011-12-09 14:37:45 EST 
If an error occurs on stdout, e.g. device full, JGit will not notice and happily 
exit with 0. This is because it uses a PrintWriter and does not check it's status.

JGit should exit with a non-zero exit code, possibly as soon as the error occurs.
Comment 1 Robin Rosenberg CLA 2012-04-25 19:28:31 EDT 
Fixing this would probably require an API change, e.g. not using PrintWriter for out.
Comment 2 Robin Rosenberg CLA 2013-02-08 01:48:17 EST 
Fix a while ago in caa362f20df1169e4a677648dce2af29d63cbcec