Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366234 - Tooltip help for menu items (Delete/Rename/others?) need better context
Summary: Tooltip help for menu items (Delete/Rename/others?) need better context
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 0.5 M2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-09 13:26 EST by Ken Walker CLA
Modified: 2012-05-21 16:47 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Walker CLA 2011-12-09 13:26:06 EST
In the Navigator, a user might use the checkbox to tick off 1 or more items, then move the mouse to a non-selected item, popup the menu and see the tooltip "Delete the selected files or folders".

But really it's just the item you used the triangle popdown on, not the selected items.

Either simply rename the tooltips to be more generic "item(s)" or there needs to be a callback to set the tooltip text before displaying it.
Comment 1 Ken Walker CLA 2012-02-07 12:29:18 EST
Currently the method in which tooltips are provided and the fact that the commands are linked to this page this will have to be revisited after 0.4.
Comment 2 Susan McCourt CLA 2012-02-09 11:12:08 EST
command.tooltip could be extended to either:

static text (like today)
or
tooltipCallback

a function that returns a context appropriate tooltip, such as

function(data) {return "the most appropriate tooltip ever for " + data.items.Location;}

I think the main thing to be wary of is that it should be a synchronous return, so we wouldn't expose this to command service extensions, it would be mostly for our internal commands.

A separate piece of work (if needed) would be extending the support to plug-ins by having the code that maps extension points to commands do the work for it.  It would require some kind of "describable" expression or parsing in the plugin properties that the extension mappings could read in order to produce the function.  (kind of how we handle validationProperties->visibleWhen today).y support this if we ha
Comment 3 Susan McCourt CLA 2012-02-09 11:23:09 EST
(In reply to comment #2)
>(kind of how we handle validationProperties->visibleWhen today).y
> support this if we ha

"kind of how we handle mapping validationProperties->visibleWhen function today"
(ignore garbled text).

I annotated bug 370903 to capture this use case.
Comment 4 Susan McCourt CLA 2012-02-10 15:52:03 EST
I just noticed the git commands use a little trick...they reset the tooltip when visibleWhen is executed.  This lets them put things like current branch name, in the tooltip.  We may want to recommend this as the actual pattern.  Because that is where you are going to know if you have one or more items, or which ones, etc.
Comment 5 Susan McCourt CLA 2012-05-18 15:29:49 EDT
moving out of 0.5M2 to 0.5 milestone until we have more specific buckets for future
Comment 6 Susan McCourt CLA 2012-05-21 16:47:03 EDT
I think we can consider this fixed by virtue of moving the "context menu" actions in the navigator to the selection menu.  So there's no longer confusion about which items you are working with.