Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366214 - [Compatibility] Add support for AbstractTrimWidgets
Summary: [Compatibility] Add support for AbstractTrimWidgets
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M5   Edit
Assignee: Remy Suen CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-09 10:54 EST by Remy Suen CLA
Modified: 2012-01-24 12:18 EST (History)
9 users (show)

See Also:

Attachments
LegacyTrim patch v1 (2.78 KB, patch)
2011-12-09 11:04 EST, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-12-09 10:54:43 EST 
Code was added to support IWorkbenchWidget. We need code to support the AbstractWorkbenchTrimWidget class which has a specialized fill(Composite, int, int) method.

+++ This bug was initially created as a clone of Bug #330106 +++

I installed the latest RTC into Eclipse 4.1 M3. When I started Eclipse, I noticed that our work item trim component is missing. There were no errors in the log. Eric indicated that he knew what the issue probably is.
Comment 1 Remy Suen CLA 2011-12-09 11:04:23 EST 
Created attachment 208174 [details]
LegacyTrim patch v1

Add a check to determine whether the instantiated IWorkbenchWidget is an implementation of the AbstractTrimWidget class. If it is, use its specialized fill(Composite, int, int) method instead of IWorkbenchWidget's fill(Composite) method.
Comment 2 Remy Suen CLA 2011-12-09 11:05:25 EST 
I'll get this in as soon as M4 is out.
Comment 3 Remy Suen CLA 2011-12-13 09:42:50 EST 
(In reply to comment #1)
> Created attachment 208174 [details]
> LegacyTrim patch v1

Patch released to master.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=616b29156c604ae0b8b4632a5abb451207d8e771
Comment 4 Remy Suen CLA 2012-01-24 12:18:11 EST 
Verified with I20120123-2200 on Windows 7.