Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366197 - incorrect fast modulo implementation
Summary: incorrect fast modulo implementation
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: IMP (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jurgen Vinju CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-09 09:55 EST by Atze van der Ploeg CLA
Modified: 2014-01-09 15:03 EST (History)
2 users (show)

See Also:

Attachments
Path to fix modulo bug (963 bytes, patch)
2011-12-09 09:55 EST, Atze van der Ploeg CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Atze van der Ploeg CLA 2011-12-09 09:55:07 EST 
Build Identifier: 20110615-0604

In org.eclipse.imp.pdb.facts.impl.fast.IntegerValue modulo was implemented such that -1 % 5 == 1, which is incorrect. It should be -1 % 5 == 4. Patch included.

Reproducible: Always
Comment 1 Atze van der Ploeg CLA 2011-12-09 09:55:42 EST 
Created attachment 208165 [details]
Path to fix modulo bug
Comment 2 Jurgen Vinju CLA 2011-12-22 04:52:15 EST 
applied and tested the patch