Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366129 - Item-level navigator copy/move broken
Summary: Item-level navigator copy/move broken
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: PC Windows 7
: P3 critical (vote)
Target Milestone: 0.4 M1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 21:44 EST by John Arthorne CLA
Modified: 2011-12-09 12:50 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-12-08 21:44:10 EST 
I20111208 on orion.eclipse.org

- Next to a file in the navigator, select "Copy to" in the menu
- Pick any destination folder

-> Nothing happens

I tried all varieties, selecting, not selecting, copying to favourite, parent, etc. Nothing happens in all cases.

With a breakpoint in fileCommands.js line 163, I see the "selectedItems" parameter is a single file rather than an array. So, on line 169 this for loop does nothing because selectedItems.length is undefined.

for (var i=0; i < selectedItems.length; i++) {
Comment 1 Susan McCourt CLA 2011-12-09 11:55:38 EST 
weird, I just released bug 365463 recently (which introduced the move/copy back at the item level).  I must have munged the commit process.
Comment 2 Ken Walker CLA 2011-12-09 12:00:29 EST 
Seems to work at the Task Bar level (Move/Copy)
Comment 3 Susan McCourt CLA 2011-12-09 12:31:14 EST 
Fixed with d03f3d952b71c6784b4158306f2f666ec05c1683
Comment 4 Susan McCourt CLA 2011-12-09 12:35:34 EST 
I can't push this fix.
Also just noticed that my fix for 365945 is not in the remote.

Something got hosed yesterday.

- The remote does not show my commit for 365945 
- My git log shows only this bug as outgoing
- If I try to fetch from remote, I'm getting "rejected."
- So I can't push this fix,
Comment 5 Susan McCourt CLA 2011-12-09 12:50:11 EST 
Did a force fetch and now could push this fix.
We aren't sure how I got into that state.