Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366116 - should org.jmock_1.2.0 not be a singleton?
Summary: should org.jmock_1.2.0 not be a singleton?
Status: RESOLVED FIXED
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Danail Branekov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 15:58 EST by David Williams CLA
Modified: 2011-12-12 04:42 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2011-12-08 15:58:33 EST 
In my code wanderings, I've noticed that org.jmock 1.2.0, in Orbit, is marked as a singleton. Is that really required? It does not have a plugin.xml file, so I'm curious if it could have been a copy/paste error, or if there is a reason for it. 

I do see it says 
Eclipse-BuddyPolicy: global
which is kind of unique, and could imagine why that is needed, but offhand don't see why that'd require it to be a singleton.  

and just thinking we should be as "least restrictive" as possible, if possible. 

While we in Orbit only have one version of org.jmock, it does seem like there are more recent versions that someone may want someday, so figured we should fix now, if there is no reason for it.
Comment 1 David Williams CLA 2011-12-08 15:59:41 EST 
Danail, any thoughts, opinions, reasons?
Comment 2 Danail Branekov CLA 2011-12-12 04:42:53 EST 
Hi David,

You are right - the singleton directive is not required. 
I have removed it and released the change as v201112120441

Regards, Danail