Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366106 - IncludableGzipFilter does not honor minGzipSize init param setting
Summary: IncludableGzipFilter does not honor minGzipSize init param setting
Status: RESOLVED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: 7.5.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 7.5.x   Edit
Assignee: Joakim Erdfelt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 15:34 EST by Joakim Erdfelt CLA
Modified: 2011-12-08 17:06 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joakim Erdfelt CLA 2011-12-08 15:34:51 EST 
When using minGzipSize init param with the IncludableGzipFilter, all content seems to be compressed regardless of minGzipSize setting.

Scenario:

The configuration for IncludeableGzipFilter
mimeTypes: application/soap+xml
excludedAgents: MSIE 6.0
minGzipSize: 2048
unchckedPrintWriter: true

Sending a javascript file at size 1024, gets compressed down to 403 bytes.
Even tho the original javascript file is both under the minGzipSize and also not present in the mimeTypes init configurable.
Comment 1 Joakim Erdfelt CLA 2011-12-08 15:35:47 EST 
The propagation of minGzipSize, mimeTypes, and bufferSize in the
IncludableGzipFilter#IncludableResponseWrapper seems to be at blame.
Comment 2 Joakim Erdfelt CLA 2011-12-08 17:06:03 EST 
Created unit test to verify failure to honor minGzipSize.
Fixed setting of minGzipSize + bufferSize + mimeTypes in new IncludableGzipWrapper.