Community
Participate
Working Groups
Build Identifier: Cloning https://bugs.eclipse.org/bugs/show_bug.cgi?id=366065 This change is required in WTP 3.3.2 Reproducible: Always
Created attachment 208119 [details] R3_3_maintenance patch
Adding the description from original bug: Add a new filter rule to extension point org.eclipse.wst.validation.validatorV2 Currently the extension point handles the following rules: fileext*, file*, projectNature*, facet*, contentType*, pattern* The idea is to add something like targetRuntime* with an id as attribute. This change would affect not only the current extension point but also the Validation Filters dialog.
approve - but because this changes an existing extension point in a maintenance release... please add PMC review questions
PMC Review requested due to UI change Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. This fix was requested by an adopter -IBM- to add a new filter rule (target runtime) to extension point org.eclipse.wst.validation.validatorV2. This request affects not only user interface but also extension points. Is there a work-around? If so, why do you believe the work-around is insufficient? There is no workaround. How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? This has been tested by hand and by running the Java EE Tools JUnit bucket (which includes validation JUnits) against it. Give a brief technical overview. Who has reviewed this fix? Carl Anderson and Chuck Bridgham have reviewed this fix. Two extension points will be updated to support a new to rule to filter between target runtimes. In addition, New Filter Rule wizard will be updated with a new option: "Target Runtime" and a new combobox where the defined workspace target runtimes will be shown. What is the risk associated with this fix? Medium - this affects two extension points that could be used or not and UI wizards.
Created attachment 208559 [details] R3_3_maintenance patch using org.eclipse.wst.common classes Seems the use of the wst.server.core is causing build troubles. Attaching a new patch and using org.eclipse.wst.common.project.facet.core classes.
Thanks for removing the server tools dep - much better
Code committed to HEAD and R3_3_maintenance for WTP 3.4 and 3.3.2. Resolving defect
