Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366065 - Add a new filter rule to include/exclude based on a target runtime
Summary: Add a new filter rule to include/exclude based on a target runtime
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: wst.validation (show other bugs)
Version: 3.2.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.5 P   Edit
Assignee: Rosendo Martinez CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 12:01 EST by Rosendo Martinez CLA
Modified: 2012-01-04 20:56 EST (History)
3 users (show)

See Also:
cbridgha: review+

Attachments
R3_2_maintenance patch (22.14 KB, patch)
2011-12-13 15:03 EST, Rosendo Martinez CLA 		no flags Details | Diff
R3_2_maintenance patch using wst.common classes (21.14 KB, patch)
2011-12-16 15:45 EST, Rosendo Martinez CLA 		shr31223: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rosendo Martinez CLA 2011-12-08 12:01:30 EST 
Build Identifier: 

Add a new filter rule to extension point org.eclipse.wst.validation.validatorV2

Currently the extension point handles the following rules: fileext*, file*, projectNature*, facet*, contentType*, pattern*

The idea is to add something like targetRuntime* with an id as attribute.

This change would affect not only the current extension point but also the Validation Filters dialog.

Reproducible: Always
Comment 1 Rosendo Martinez CLA 2011-12-13 15:03:11 EST 
Created attachment 208334 [details]
R3_2_maintenance patch

R3.2.5P is not ready yet. I am starting with R3_2_maintenance.
Comment 2 Chuck Bridgham CLA 2011-12-13 15:20:42 EST 
This patch seems ok, but I am worried about the new dependency on server tools.
I suppose this can't be avoided
Comment 3 Rosendo Martinez CLA 2011-12-16 15:45:17 EST 
Created attachment 208506 [details]
R3_2_maintenance patch using wst.common classes

Seems like the use of the wst.server.core is causing build troubles. Attaching a new patch and using org.eclipse.wst.common.project.facet.core classes.
Comment 4 Chuck Bridgham CLA 2011-12-19 10:57:32 EST 
Much better - thanks - approved
Comment 5 Roberto Sanchez Herrera CLA 2012-01-04 20:56:31 EST 
This code was already committed. Resolving bug.