Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366037 - [Compatibility] org.eclipse.ui.actionsSets compatibility - pulldown attribute not working against 4.2 platform
Summary: [Compatibility] org.eclipse.ui.actionsSets compatibility - pulldown attribute...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.2 M6   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 367159 367823
Blocks: 334303
  Show dependency tree
 
Reported: 2011-12-08 08:53 EST by Karen Butzke CLA
Modified: 2012-03-13 11:32 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2011-12-08 08:53:04 EST 
My project is part of wtp and we have moved to targeting eclipse 4.2M3

I have a pulldown toolbar button defined which was working fine when targeting eclipse 3.7 platform. Now that I am targeting 4.2 platform, the toolbar pulldown is just a button, no longer a pulldown. I can fix this easily enough by changing pulldown="true" to style="pulldown". My concern is for compatibility purposes. I just happened to notice that my toolbar button was no longer a pulldown. The pulldown attribute is deprecated, but if it's not going to work at all I think it should be removed from the .exsd.

<extension point="org.eclipse.ui.actionSets">

	<actionSet
		description="%JptCreationActionSet.description"
		id="org.eclipse.jpt.jpa.ui.JptCreationActionSet"
		label="%JptCreationActionSet.label">
		<action
				class="org.eclipse.jpt.jpa.ui.internal.wizards.NewEntityDropDownAction"
				disabledIcon="icons/full/etool16/new_entity_wiz.gif"
			icon="icons/full/etool16/new_entity_wiz.gif"
			id="org.eclipse.jpt.jpa.ui.NewEntityAction"
			label="%NewEntityAction.label"
			pulldown="true"
			toolbarPath="Normal/JptWizards">
		</action>
	</actionSet>		
</extension>
Comment 1 Paul Webster CLA 2011-12-08 08:57:11 EST 
All of the action extension points are deprecated in the 4.x stream.  But I think we can make the pulldown="true" work.

PW
Comment 3 Paul Webster CLA 2012-01-24 13:53:12 EST 
In I20120123-2200

Karen, could you confirm this works for you in a recent build?

PW
Comment 4 Karen Butzke CLA 2012-01-31 09:47:58 EST 
Is the fix in the M5 build?
Comment 5 Karen Butzke CLA 2012-01-31 09:50:56 EST 
I downloaded 4.2M5, and this bug is not fixed. Looks like that contains org.eclipse.ui plug-in from 1/18
Comment 6 Paul Webster CLA 2012-01-31 10:11:17 EST 
(In reply to comment #5)
> I downloaded 4.2M5, and this bug is not fixed. Looks like that contains
> org.eclipse.ui plug-in from 1/18

The fix is in M5.  org.eclipse.ui_3.102.0.v20120118-1650 and org.eclipse.ui.workbench_3.103.0.v20120126-1500

I just ran it with extension below and I get a toolbar with a dropdown filled in from the z.ex.rcp.mail.MyTBDropdown.getMenu(Control) method.


   <extension
         point="org.eclipse.ui.actionSets">
      <actionSet
            id="z.ex.rcp.mail.actionSet1"
            label="MyActionSet"
            visible="true">
         <action
               class="z.ex.rcp.mail.MyTBDropdown"
               icon="icons/sample3.gif"
               id="z.ex.rcp.mail.action1"
               label="MyTB"
               pulldown="true"
               style="push"
               toolbarPath="Normal/JptWizards"
               tooltip="MyTB">
         </action>
      </actionSet>
   </extension>

Is M5 set as your target platform?

PW
Comment 7 Karen Butzke CLA 2012-01-31 10:32:57 EST 
The fix only works for me if I also add style="push". I did not have to have this set for the 3.7 platform
Comment 8 Paul Webster CLA 2012-01-31 10:42:24 EST 
Ah, OK.
PW
Comment 10 Paul Webster CLA 2012-03-13 11:32:02 EDT 
In I20120313-0610
PW