Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365934 - MouseEvent#button, SWT#BUTTON*, and SWT#MOD* should spell out usual mapping
Summary: MouseEvent#button, SWT#BUTTON*, and SWT#MOD* should spell out usual mapping
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-07 12:27 EST by Markus Keller CLA
Modified: 2012-10-19 10:14 EDT (History)
3 users (show)

See Also:

Attachments
proposed fix (3.11 KB, patch)
2011-12-07 12:32 EST, Markus Keller CLA 		no flags Details | Diff
patch 2 (3.70 KB, patch)
2012-02-14 16:39 EST, Markus Keller CLA 		no flags Details | Diff
patch 3 (3.18 KB, patch)
2012-08-14 10:11 EDT, Markus Keller CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-12-07 12:27:09 EST 
MouseEvent#button, SWT#BUTTON*, and SWT#MOD* should spell out the commonly used physical mapping of these buttons/keys.

I always have to guess the mapping of the middle and right mouse buttons, and the common order of modifiers.
Comment 1 Markus Keller CLA 2011-12-07 12:32:33 EST 
Created attachment 208058 [details]
proposed fix
Comment 2 Felipe Heidrich CLA 2011-12-09 12:17:56 EST 
Hi Markus, I can't apply this patch

could please create a commit in your local repo and export it to me using:
git format-patch -M origin/master

(supposing your master is only commit ahead of origin/master)
Comment 3 Markus Keller CLA 2012-02-14 16:39:19 EST 
Created attachment 211011 [details]
patch 2
Comment 4 Markus Keller CLA 2012-08-14 10:11:09 EDT 
Created attachment 219864 [details]
patch 3

Rebased patch onto master. This is a trivial Javadoc fix.