Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365906 - GitQuickDiffProvider.isEnabled() breaks Quick Diff for CVS if Git provider is active
Summary: GitQuickDiffProvider.isEnabled() breaks Quick Diff for CVS if Git provider is...
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.3   Edit
Assignee: Kevin Sawicki CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-07 09:48 EST by Markus Keller CLA
Modified: 2012-01-26 03:29 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-12-07 09:48:58 EST 
Follow-up to bug 358245. That change fixed the problem for local files, but the current implementation still breaks Quick Diff for CVS files if the Git provider is active.

Test Case:
1. set Git as reference provider ('Quick Diff' preference page)
2. check out a CVS project
3. open a file and start typing
==> changes are not shown in ruler.

GitQuickDiffProvider#isEnabled() should call

    RepositoryProvider.
        getProvider(resource.getProject(), "org.eclipse.egit.core.GitProvider")

or do

    RepositoryProvider.getProvider(resource.getProject()) instanceof GitProvider

as in GitDocument#create(IResource)
Comment 1 Kevin Sawicki CLA 2011-12-14 19:27:27 EST 
Proposed fix pushed to http://egit.eclipse.org/r/4824
Comment 2 Matthias Sohn CLA 2012-01-24 18:01:17 EST 
merged as eb97196fe35bd5873e12301baa641f696b30c860
Comment 3 Dani Megert CLA 2012-01-26 03:29:53 EST 
Verified in 1.3.0.201201252016.