Community
Participate
Working Groups
At least, not as far as I can see. Is there a reason for this? It has no "plugin.xml" file. The previous version 1.7.1 seems to have not been a singleton. I'm wondering if this was just a "typo"?
Michael, can you think of any reason this is a singleton or should I just change it?
(In reply to comment #1) > Michael, can you think of any reason this is a singleton or should I just > change it? I can't think of a reason. I also can't see a reason for this being a problem - i.e. you can still use another version of Ant in Eclipse
(In reply to comment #2) > (In reply to comment #1) > > Michael, can you think of any reason this is a singleton or should I just > > change it? > > I can't think of a reason. I also can't see a reason for this being a problem - > i.e. you can still use another version of Ant in Eclipse No ... its currently causing no "problem" ... I am just looking for OSGi correctness and best practice ... "just in case", "for the future", etc.
Ok, I've removed the singleton flag. Thanks.
I see the fix for bug 369098 "automatically" included this fix too, so am changing target to Indigo SR2, but non-singleton will also appear in Juno M5 (different from M4). I think it is be perfectly safe to change to non-singleton in maintenance release, and I think it for the best. I started thinking about this after hearing of some Helios users (which includes Ant 1.7) which wanted to use some Android SDK which required Ant 1.8 so they might have to get or install Ant 1.8 from Orbit. I suspect all would have worked even being a singleton, but ... in case 1.7 and 1.8 do end up in same install ... it'll be more certain to work if both are non-singletons, since there's no reason they have to be singletons. Feel free to say (quickly) if anyone sees this change as a problem in maintenance release.
