Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365806 - Use common regex util
Summary: Use common regex util
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 M1   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-06 15:30 EST by Mark Macdonald CLA
Modified: 2011-12-06 18:45 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-12-06 15:30:53 EST 
While fixing Bug 364481 I added a library for dealing with regex stuff: "regex.js". I see at least 2 other places in the code that are using copied "escapeRegex" functions. They need to be calling the library function instead.
Comment 1 Mark Macdonald CLA 2011-12-06 15:55:51 EST 
Hmm, fixing this would make editorFeatures.js pull in regex.js just to support case-insensitive search in incremental find. Anyone consuming the editor via the <script> method will need to write out the extra dependency. 

We might want to avoid this by splitting up editorFeatures into smaller units of functionality, which consumers could add (or not) piece-by-piece.