Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365780 - [dstore] codepage conversion should only occur for different encodings
Summary: [dstore] codepage conversion should only occur for different encodings
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M4   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 365784
  Show dependency tree
 
Reported: 2011-12-06 12:52 EST by David McKnight CLA
Modified: 2012-02-06 09:36 EST (History)
0 users

See Also:

Attachments
patch to check encodings (5.78 KB, patch)
2011-12-06 13:03 EST, David McKnight CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David McKnight CLA 2011-12-06 12:52:40 EST 
Currently the default codepage converter tries to do a conversion even if the remote and local encodings are the same and the file is of zero bytes.
Comment 1 David McKnight CLA 2011-12-06 12:59:00 EST 
There was already a fix for the zero-length case, although that needs to get backported - I'll do that with the encoding check.
Comment 2 David McKnight CLA 2011-12-06 13:03:24 EST 
Created attachment 208010 [details]
patch to check encodings
Comment 3 David McKnight CLA 2011-12-06 13:10:40 EST 
I've committed the change to the HEAD stream.