Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365759 - Key bindings imported from preferences are not always immediately applied
Summary: Key bindings imported from preferences are not always immediately applied
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M6   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-06 11:08 EST by Brian de Alwis CLA
Modified: 2012-03-13 06:59 EDT (History)
2 users (show)

See Also:

Attachments
Patch (3.17 KB, patch)
2012-02-29 14:55 EST, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian de Alwis CLA 2011-12-06 11:08:28 EST 
Version: 4.2 (for M4)
BuildId: I20111205-2330

If you import a preferences that includes key bindings, some bindings are not applied.  In particular, I bind File > Import to Ctrl-Cmd-I (on the mac), and it never takes effect until I restart.

I suspect the problem may be the same as bug 365724 comment 3, ultimately that the menu item is from an MMenuContribution.
Comment 1 Remy Suen CLA 2012-02-29 12:49:29 EST 
It does show up in the 'Keys' preference page though.
Comment 2 Remy Suen CLA 2012-02-29 14:55:34 EST 
Created attachment 211835 [details]
Patch

When the BindingPersistence is asked to reread (when a preference changes), persist the information to the model after the reading process has completed.
Comment 4 Dani Megert CLA 2012-03-13 06:59:27 EDT 
Verified in 4.2-I20120312-1730.