Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365723 - Problem with Escape to close completion (ContentProposalAdapter) close dialog.
Summary: Problem with Escape to close completion (ContentProposalAdapter) close dialog.
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.5 M5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 330461
  Show dependency tree
 
Reported: 2011-12-06 08:18 EST by Angelo ZERR CLA
Modified: 2012-01-25 08:33 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angelo ZERR CLA 2011-12-06 08:18:57 EST 
Hi,

I have completion with ContentProposalAdapter in a Dialog. When popup completion opens and I key "Esc" to close the popup, the popup closes (it"s OK) but my Dialog closes too (not OK).

The case with "Esc" which works is if I open the popup, I select an item to the popup with mouse and I key "Esc", the popup closes and my Dialog DOENS'T close.

I have tested that with FF, Google Chrome and IE8.

Regards Angelo
Comment 1 Ralf Sternberg CLA 2011-12-08 06:02:34 EST 
Seems to be related to bug 329926. Probably Escape and Return keys need to be prevented when any pop-ups are opened.
Comment 2 Ivan Furnadjiev CLA 2011-12-09 03:46:56 EST 
After a quick look even the ESC key event is canceled on the server (doit = false ContentProposalAdapter line 368) this event reaches the dialog shell.
Comment 3 Ivan Furnadjiev CLA 2012-01-25 08:33:35 EST 
ESC and ENTER keys have been added to the CANCEL_KEYS. Dialog should not be affected by ESC and ENTER anymore.