Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365714 - [ModelExplorer][Refactoring] Rewrite Facets and Customization
Summary: [ModelExplorer][Refactoring] Rewrite Facets and Customization
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Vincent Lorenzo CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 365744
Blocks: 359057 379553
  Show dependency tree
 
Reported: 2011-12-06 07:48 EST by Vincent Lorenzo CLA
Modified: 2014-04-11 06:17 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Lorenzo CLA 2011-12-06 07:48:58 EST 
There are several plugins which contributes to the ModelExplorer in Papyrus : 
	- oep.views.modelexplorer
	- oep.infra.table.modelexplorer
	- oep.uml.modelexplorer
	- oep.uml.diagram.modelexplorer

Some of these plugins provide customizations and facets for the ModelExplorer. Some of them are not correctly written and not owned by the right plugin. 

For example : 
	- oep.uml.modelexplorer provides customization and facets for the gmf Diagram and the current facet for Diagram extends Element instead of EObject (or EModelElement). After the refactoring, we should get a new Facet extending EObject inside a new plugin, called oep.infra.gmfdiag.modelexplorer
	- oep.uml.diagram.modelexplorer should be merge with the new plugin oep.infra.gmfdiag.modelexplorer.

To summarize, the goal of this refactoring are : 
	- to declare facet and customization on EOBject instead of uml.Element when it is possible, to avoid dependency and redundancy
	- move code into the right plugins
Comment 1 Vincent Lorenzo CLA 2011-12-07 04:26:45 EST 
In R6361 : Create and commit the new plugin oep.infra.gmfdiag.modelexplorer. This plugin provides customizations and facets written on EObject and not on Diagram or Element. Currently this plugin compiles, but doesn't work, because EMF-Facet doesn't manage inheritance between metamodel. So, I keep the current facets and customizations which come from oep.uml.modelexplorer
Comment 2 Vincent Lorenzo CLA 2011-12-07 04:30:36 EST 
In R6362 : in oep.views.modelexplorer : 
	Create customization for Ecore. This customization provides the configuration for EObject : isReadOnly + hide MetaclassName. 
	Currently the plugin compiles but doesn't work, there is not inheritance between metamodels with EMF-Facet : customization on EObject are not applied on Diagram and uml.Element.
Comment 3 Vincent Lorenzo CLA 2011-12-07 04:34:26 EST 
In R6363 : oep.uml.modelexplorer and oep.uml.diagram.modelexplorer : refactoring + queries for diagrams are now deprecated (but not removed), because the EMF-Facet bug 365744 : is not fixed
Comment 4 Vincent Lorenzo CLA 2011-12-07 04:37:23 EST 
In R6364 : remove unused classes + add FIXME in the queries -> they should be declared on EObject and not on Element, when the EMF-Facet bug 365744 will be fixed.
Comment 5 Vincent Lorenzo CLA 2011-12-07 07:21:08 EST 
In R6365 Update the psf for the new plugin oep.infra.gmfdiag.modelexplorer
Comment 6 Vincent Lorenzo CLA 2011-12-13 07:45:00 EST 
In R6437 : add the gmf dependencies in the manifest.
Comment 7 Camille Letavernier CLA 2012-04-11 05:18:21 EDT 
Target Milestone : 0.9.1 (SR1)
Comment 8 Camille Letavernier CLA 2014-04-11 06:17:51 EDT 
Done in 1.0.0. All facets/customs have been rewritten during the migration to EMF Facet 0.2