Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365670 - Refactor existing "edit" extension points to use content types
Summary: Refactor existing "edit" extension points to use content types
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-05 16:40 EST by Mark Macdonald CLA
Modified: 2012-01-03 12:29 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-12-05 16:40:25 EST 
These services require clients to pass filename patterns (or something similarly weird) to scope to a particular kind of file. They should accept content types instead.

 - orion.edit.contentAssist
 - orion.edit.highlighter
 - orion.edit.outliner
 - orion.edit.validator

Should maintain backwards compatibility if possible (for the outliner case especially, since the "nonymous" outliner is so useful).
Comment 1 Mark Macdonald CLA 2011-12-06 10:46:58 EST 
Also
 - orion.edit.model
Comment 2 Mark Macdonald CLA 2012-01-03 12:29:51 EST 
Fixed with these commits:

* 06cbf18 2012-01-03 | Bug 365670 - Make orion.edit.model use content types (HEAD, origin/master, origin/HEAD, master) [Mark Macdonald]
* a2dcebd 2011-12-19 | Bug 365670 - Make orion.edit.highlighter use content types [Mark Macdonald]
* 749eca5 2011-12-20 | Bug 365670 - Make orion.edit.validator use content types [Mark Macdonald]
* 8611bef 2011-12-20 | Bug 365670 - Make orion.edit.contentAssist use content types [Mark Macdonald]
* 66ed6d9 2011-12-20 | Bug 365670 - Make orion.edit.outliner use content types [Mark Macdonald]
* 5ae5417 2011-12-20 | Bug 365670 - Make content types into a ContentTypeService [Mark Macdonald]

Backwards compatibility is provided with the filename-pattern approach that we were using before. I tested with the HTML outliner plugin [1] and CSSLint [2] which still use patterns; both seem to work OK.

[1] http://jarthorn.github.com/html-tools/htmlOutlinePlugin.html
[2] http://mamacdon.github.com/0.3/plugins/csslint/csslintPlugin.html