Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365576 - [client] Add Save Patch action
Summary: [client] Add Save Patch action
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 367081
Blocks: 361425
  Show dependency tree
 
Reported: 2011-12-05 07:10 EST by Tomasz Zarna CLA
Modified: 2011-12-20 06:22 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-12-05 07:10:19 EST
The action could be added to the Git Status page, or to any page showing a comparison.
Comment 1 libing wang CLA 2011-12-05 09:52:06 EST
Is this an action to save the patched file(original file + diff) or just the unified diff ?
Lets confirm the work flow if it is the first case. Here is my assumption:
1.take action on "apply patch" for a file. (will this action be invoked from navigator?)
2.select the patch file from where ever you stored it, or just paste the patch.
3.The compare editor opens up and show as preview.
4.In the compare editor, save the patched file.
Comment 2 Tomasz Zarna CLA 2011-12-05 10:55:12 EST
(In reply to comment #1)
> Is this an action to save the patched file(original file + diff) or just the
> unified diff ?

I was thinking about saving the diff.

> 1.take action on "apply patch" for a file. (will this action be invoked from
> navigator?)

See bug 365575, comment 0. My initial idea was to add the action to the Repos page, but drag'n'droppin' a patch on the Git Status page makes sense to me as well. Would you like to see it somewhere else?
Comment 3 Tomasz Zarna CLA 2011-12-05 10:59:42 EST
I said drag'n'drop but the first cut will probably look similar to the "Import from ZIP" action when you browse your files looking for the patch.
Comment 4 Tomasz Zarna CLA 2011-12-20 06:22:00 EST
Fixed with 309cbd3a9b7c6e0d3edd0d8010cbbf651d3dbeb2
Comment 5 Tomasz Zarna CLA 2011-12-20 06:22:36 EST
.