Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365547 - [xtext][ui][wizard] don't generate require-bundle for org.apache.commons.logging
Summary: [xtext][ui][wizard] don't generate require-bundle for org.apache.commons.logging
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.1.1   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: M6   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 284716
Blocks:
  Show dependency tree
 
Reported: 2011-12-05 02:29 EST by Knut Wannheden CLA
Modified: 2017-09-19 18:11 EDT (History)
2 users (show)

See Also:
jan: juno+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Knut Wannheden CLA 2011-12-05 02:29:27 EST 
Currently the XtextProjectCreator generates a Require-Bundle *and* a Import-Package statement for org.apache.commons.logging. I think we should remove the former and mark the latter as optional, as it's only required by the generator.
Comment 1 Knut Wannheden CLA 2012-02-07 02:26:29 EST 
The same is true for log4j.

Also note that there are a few projects in the Xtext repository which contain Require-Bundle directives for log4j: org.eclipse.xtext.purexbase and org.eclipse.xtext.doc. It would be nice if these could be replaced by Import-Package directives to allow clients to use slf4j instead of log4j.
Comment 2 Dennis Huebner CLA 2012-02-07 03:32:51 EST 
(In reply to comment #1)
> The same is true for log4j.
> 
> Also note that there are a few projects in the Xtext repository which contain
> Require-Bundle directives for log4j: org.eclipse.xtext.purexbase and
> org.eclipse.xtext.doc. It would be nice if these could be replaced by
> Import-Package directives to allow clients to use slf4j instead of log4j.

Good news: org.eclipse.xtext.doc is now a non java project
Bad news: org.eclipse.xtext.purexbasen reexports org.apache.log4j so cant't be replaced by import package. Would an optional dependency + import package help here?
Comment 3 Knut Wannheden CLA 2012-02-07 04:08:24 EST 
I knew I had come across this before. I just couldn't find bug 284716 anymore.

I think the reexports can also be attributed to XtextProjectCreator, for whatever reason. Wouldn't it be possible to simply "forget about" the reexports. Do we really expect clients to depend on this?
Comment 4 Dennis Huebner CLA 2012-02-07 04:48:22 EST 
(In reply to comment #3)
> I knew I had come across this before. I just couldn't find bug 284716 anymore.
Bugzilla won't search for a Bug because it knows you don't find bug 284716, it finds you. :)

> I think the reexports can also be attributed to XtextProjectCreator, for
> whatever reason. Wouldn't it be possible to simply "forget about" the
> reexports. Do we really expect clients to depend on this?

We can remove bundle dependency from purexbase cause it just an example.
Comment 5 Dennis Huebner CLA 2012-02-24 10:50:16 EST 
Dependency is fixed, so closing.
Comment 6 Karsten Thoms CLA 2017-09-19 18:01:33 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 7 Karsten Thoms CLA 2017-09-19 18:11:54 EDT 
Closing all bugs that were set to RESOLVED before Neon.0