Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365470 - MToolItemTest's testActionSetAddedToMyToolbar fails
Summary: MToolItemTest's testActionSetAddedToMyToolbar fails
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.2 M4   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-02 14:12 EST by Remy Suen CLA
Modified: 2011-12-08 07:57 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-12-02 14:12:10 EST 
junit.framework.ComparisonFailure: null expected:<group[2]> but was:<group[1]>
	at junit.framework.Assert.assertEquals(Assert.java:81)
	at junit.framework.Assert.assertEquals(Assert.java:87)
	at org.eclipse.e4.ui.menu.tests.MToolItemTest.testActionSetAddedToMyToolbar(MToolItemTest.java:198)

I originally thought it might have been due to the changes for bug 331662 but that doesn't seem to be the case. I suppose that change only affected view actions and not the main toolbar.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9954a5ef4e59a5d39a1a491f7272446ce76c590a
Comment 1 Remy Suen CLA 2011-12-02 14:29:29 EST 
We inverted the processing of actions a few months back and this seems to be the cause.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a0aef6d37a64f13884468bb0a296d74f7c1947fd

At least, if the actions were processed in an inverse order in ActionSet, then the test itself would pass. However, other tests start failing. :)
Comment 2 Paul Webster CLA 2011-12-08 07:50:22 EST 
This is a bug in the test, now.

PW