Community
Participate
Working Groups
Build Identifier: Look for "commit.lane.position = newPos" in org.eclipse.jgit.revplot.PlotCommitList.handleBlockedLanes(int, PlotCommit<L>, int). This line indirectly modifies object's hashcode, but this PlotLane is already contained in "activeLanes" HashSet. I think you see where it goes :) Changing it to the following text fixes the issue. "activeLanes.remove(commit.lane); commit.lane.position = newPos; activeLanes.add(commit.lane);" P.S. Sorry for not doing it the right git way: with a new commit, patch etc. I'll read egit/jgit contributors guide, honestly :) Reproducible: Always Steps to Reproduce: Look at 90c11cbaeb83ee9b02238cbd2c0e5bcf68068772 in jgit repo. Its lane is displayed at position 30+ while positions 7-30 are vacant.
please retry with todays nightly, Chris' fix http://egit.eclipse.org/r/#change,4735 was submitted to stable-1.2
No Matthias, Vadim is already looking at my new code. I also noticed that we are using with my latest fix too many lanes and I now understand why. That's a tricky Thanks again Vadim! I fixed it with http://egit.eclipse.org/r/4743. Matthias, do we want that fix on 1.2?
(In reply to comment #2) > No Matthias, Vadim is already looking at my new code. > > I also noticed that we are using with my latest fix too many lanes and I now > understand why. That's a tricky Thanks again Vadim! I fixed it with > http://egit.eclipse.org/r/4743. Matthias, do we want that fix on 1.2? yes, please retarget this change to 1.2 (with Gerrit 2.2 you can simply push the same change to refs/for/stable-1.2 and abandon the other change, I'll merge 1.2 back to master soon
Done. http://egit.eclipse.org/r/#change,4744 is the new change for 1.2. Change for master is abandoned
merged as 251bc02840a2e722a6cf660e4adde0e63d3d2de1
