Community
Participate
Working Groups
Build Identifier: And should contain only one. Reproducible: Always
Created attachment 207831 [details] proposed patch
Agreed that there should only be one. I think the existing code allows for different log configurations for different instances of the ProxyServlet - that seems to be deliberate, so I'd ask around a bit before removing that ability. Also, it seems that quite a few lines in the patch are whitespace replacements - do you know if your settings are up-to-date, or if that is mal-formatted original src? Jan
Having different loggers for different instances might make sense for some ppl. I still think it's an edge case, but if you like to keep it, lets keep it in. I've an eclipse save action which removes trailing whitespaces.
Well, its likely that you could have 2 ProxyServlets configured, both for different addresses, and you'd like to know which one generated the log messages. That's why I think we need to keep the code that calls createLogger(). If anything, we probably should remove the static logger that probably got added when the logging system changed. So we should probably replace all calls to LOG.x with _log.x ? Jan
Created attachment 207959 [details] proposed patch Yes, as said. I see the use case and I agree. Atached is another patch removing the static logger. It has only been used in the onException methods.
Leave it up to you to decide if we keep the current code or remove the static logger. Both make sense, but I'd prefer to have only one logger per instance and remove the static one.
Hi Thomas, I think your second patch is best (ie remove the static logger). But ... can we have a patch that does not include all of the whitespace changes? It's essentially a 1 line patch, but gets obscured by all the whitespace changes. I'd just make the change myself, but its good to get you karma for submitting patches :) Jan (In reply to comment #6) > Leave it up to you to decide if we keep the current code or remove the static > logger. Both make sense, but I'd prefer to have only one logger per instance > and remove the static one.
Created attachment 208245 [details] proposed patch Patch without whitespace changes attached. However I think those trailing whitespaces should be removed. If you want I can provide a patch with two commmits. One for the whitespaces and one for the actual change.
Yes, a patch without the whitespaces would be good. Assigning to you.
Created attachment 209093 [details] Patch removing the logger
Created attachment 209094 [details] 2nd commit removing the whitespaces Hey Jan, please use the last two patch files as you wish. The first is the actual patch removing the logger and the second removes the unnecessarily whitespaces. Cheers, Thomas
Reviewed and applied patches.
