Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365358 - NPE when opening review with postponed files included
Summary: NPE when opening review with postponed files included
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Sebastien Dubois CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 365434 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-12-01 14:44 EST by Sebastien Dubois CLA
Modified: 2012-03-19 15:56 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastien Dubois CLA 2011-12-01 14:44:28 EST 
We get a NPE when opening reviews with psotponed files without anomalies included in them.  Postponed files should never exist without child postponed anomalies so investigation is needed to see why they were imported in the first place.  Also the situation should not prevent reviews from opening


java.lang.NullPointerException
	at org.eclipse.mylyn.reviews.r4e.ui.internal.model.R4EUIPostponedFile.open(R4EUIPostponedFile.java:236)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.model.R4EUIPostponedContainer.open(R4EUIPostponedContainer.java:126)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.model.R4EUIReviewBasic.open(R4EUIReviewBasic.java:642)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.commands.OpenElementHandler$1.runInUIThread(OpenElementHandler.java:107)
	at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4140)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3757)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
Comment 1 Sebastien Dubois CLA 2011-12-02 09:28:34 EST 
*** Bug 365434 has been marked as a duplicate of this bug. ***
Comment 2 Sebastien Dubois CLA 2011-12-02 16:04:50 EST 
Code is now included to prevent NPE upon opening the review when there is a postponed file with no anomalies.  We now have to implement part 2 of the solution, which is to fix the root cause that make childless postponed files to appear upon import
Comment 3 Sebastien Dubois CLA 2012-03-19 15:56:13 EDT 
The fix is implemented and will be included in the next release