Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365333 - [xtext][ui][outline] don't require double click
Summary: [xtext][ui][outline] don't require double click
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.1.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-01 11:21 EST by Knut Wannheden CLA
Modified: 2017-09-19 17:38 EDT (History)
1 user (show)

See Also:
jan: juno+


Attachments
proposed patch (1.73 KB, patch)
2011-12-02 06:05 EST, Knut Wannheden CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Knut Wannheden CLA 2011-12-01 11:21:40 EST
I think the behavior of the outline view should be that of JDT's outline view:

* Single clicking on a node selects and reveals the corresponding declaration in the editor but the view maintains focus
* Double clicking a node also selects and reveals the declaration but transfers the UI focus to the editor

It's mainly the double clicking I find a bit annoying (keep forgetting it :-)).
Comment 1 Knut Wannheden CLA 2011-12-01 11:23:35 EST
Forgot to mention what the current behavior of the Xtext outline is:

* Single click doesn't do anything (except selecting the node in the outline tree view)
* Double clicking selects and reveals in the editor but the UI focus remains on the outline view
Comment 2 Jan Koehnlein CLA 2011-12-01 12:17:37 EST
Apart from the focus on double-click, the behavior is exctly as in JDT. Note that JDT hides the "Link with editor" toggle button in the "View Menu" (below the triangular button) of the outline.
Comment 3 Knut Wannheden CLA 2011-12-01 14:46:25 EST
Yes, you're right. Maybe it's just that link with editor is enabled by default in JDT and not in the Xtext outline.
Comment 4 Knut Wannheden CLA 2011-12-02 06:05:07 EST
Created attachment 207829 [details]
proposed patch

Simple patch to make the link with editor the default.
Comment 5 Jan Koehnlein CLA 2011-12-02 11:14:11 EST
Applied your patch and added a focus change on double click.
Comment 6 Karsten Thoms CLA 2017-09-19 17:26:52 EDT
Closing all bugs that were set to RESOLVED before Neon.0
Comment 7 Karsten Thoms CLA 2017-09-19 17:38:09 EDT
Closing all bugs that were set to RESOLVED before Neon.0