Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365132 - With fix for 357110, member types are processed more than once
Summary: With fix for 357110, member types are processed more than once
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.7.2   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 364749 (view as bug list)
Depends on: 358414
Blocks:
  Show dependency tree
 
Reported: 2011-11-29 15:40 EST by Curtis Windatt CLA
Modified: 2011-11-30 11:53 EST (History)
5 users (show)

See Also:
curtis.windatt.public: review+
Michael_Rennie: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2011-11-29 15:40:10 EST 
Bug 357110 was backported to 3.7.2 causing test failures (bug 364749).  We therefore need to backport this fix.

+++ This bug was initially created as a clone of Bug #358414 +++

Inside the processing of tag validation, the enclosing compilation unit is retrieved for each type that is processed. Now member types are returned and this means they end up being processed more than once.
This caused test failures in I20110920-1501.
Comment 1 Curtis Windatt CLA 2011-11-29 15:42:38 EST 
*** Bug 364749 has been marked as a duplicate of this bug. ***
Comment 2 Curtis Windatt CLA 2011-11-29 16:13:11 EST 
Mike, please review for 3.7.1 inclusion
Comment 3 Curtis Windatt CLA 2011-11-29 16:13:42 EST 
Fixing reviewers.

+1 as component lead, all tests pass with the fix.
Comment 4 Ankur Sharma CLA 2011-11-30 04:25:45 EST 
+1
Tested the patch with M20111124-1052. All tests pass.
Comment 5 Curtis Windatt CLA 2011-11-30 11:00:25 EST 
Fixed in R3_7_maintenance.  Mike will verify.
Comment 6 Michael Rennie CLA 2011-11-30 11:53:08 EST 
VERIFIED