Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365104 - LaunchConfigurationEditDialog does not return correct return code when the user clicks "Continue"
Summary: LaunchConfigurationEditDialog does not return correct return code when the us...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.7.1   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.8 M4   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 365108 365222
  Show dependency tree
 
Reported: 2011-11-29 12:01 EST by Samantha Chan CLA
Modified: 2011-11-30 12:01 EST (History)
1 user (show)

See Also:

Attachments
fix (1.63 KB, patch)
2011-11-29 13:09 EST, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samantha Chan CLA 2011-11-29 12:01:20 EST 
The fix here:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=338847

introduced a major regression in our product.

The fix causes the LaunchConfigurationEditDialog to always return "cancel" as the return code even when the user has clicked the "Continue" button.  As a result, our launch configuration delegate is broken and our customer is unable to launch.

Requesting a fix in the LaunchConfugrationEditDialog to return "OK" when the "continue" button is pressed.  Return "cancel" if the cancel button is pressed.
Comment 1 Michael Rennie CLA 2011-11-29 12:45:53 EST 
This should also be fixed in 3.7.2. I opened bug 365108 to track that work.
Comment 2 Michael Rennie CLA 2011-11-29 13:09:48 EST 
Created attachment 207676 [details]
fix

Patch that makes sure the continue button always returns the correct result