Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365073 - Patcher#applyAll doesn't expect null progress monitor
Summary: Patcher#applyAll doesn't expect null progress monitor
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.8 M4   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-29 10:18 EST by Tomasz Zarna CLA
Modified: 2011-12-02 11:35 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-11-29 10:18:55 EST 
master

There are few checks "if (pm != null)" at the begining of the method, but couple lines later, when #store and #delete methods are called, SubProgressMonitors are created, which will fail with AssertionFailedException if null monitor is used.
Comment 1 Tomasz Zarna CLA 2011-12-02 11:35:24 EST 
Fixed with 888c23e142538e6d5c56b0c75f47aa39abd26956. Available in builds >= N20111202-2000.