Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 365072 - Add javadoc, generics and reformat code
Summary: Add javadoc, generics and reformat code
Status: CLOSED FIXED
Alias: None
Product: Gemini.Management
Classification: RT
Component: Core (show other bugs)
Version: pre-release   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.0.0.M01-incubation   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-29 10:12 EST by Lazar Kirchev CLA
Modified: 2012-06-07 06:08 EDT (History)
1 user (show)

See Also:

Attachments
Patch containing the fix. (127.89 KB, application/octet-stream)
2011-11-30 02:41 EST, Lazar Kirchev CLA 		no flags Details
To be applied after the first patch to apply a second set of code tidy up (48.04 KB, application/octet-stream)
2011-12-01 12:13 EST, Chris Frost CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lazar Kirchev CLA 2011-11-29 10:12:10 EST 
Javadoc should be added where not available.

Generics should be used.

Formatting of the code should be improved.
Comment 1 Lazar Kirchev CLA 2011-11-30 02:41:44 EST 
Created attachment 207704 [details]
Patch containing the fix.
Comment 2 Chris Frost CLA 2011-12-01 12:13:36 EST 
Created attachment 207800 [details]
To be applied after the first patch to apply a second set of code tidy up
Comment 4 Chris Frost CLA 2011-12-02 05:33:13 EST 
I will commit my patch when I get commit rights, I have asked the web master.
Comment 5 Chris Frost CLA 2011-12-06 08:34:02 EST 
Fixed with commits 
8ac90a46f788f12bc25bfb47ba1523312a3225a8
and 
7f296c510493c0b9d2b388ce6a204ea561edc15a
for the two patches attached to this issue.
Comment 6 Chris Frost CLA 2011-12-06 10:25:57 EST 
Setting the target milestone for the first shipping