Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364997 - HTML code folding slows down typing in PHP files
Summary: HTML code folding slows down typing in PHP files
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP Core CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-28 14:09 EST by Natalia Bartol CLA
Modified: 2020-05-14 11:17 EDT (History)
2 users (show)

See Also:

Attachments
HTML folding in PHP files optimized - patch (3.99 KB, patch)
2011-11-28 14:14 EST, Natalia Bartol CLA 		jacek.pospychala: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Natalia Bartol CLA 2011-11-28 14:09:44 EST 
Build Identifier: 

Typing in big PHP files that contains PHP blocks mixed with HTML may become quite slow. Unchecking "Enable folding" in Structured Text Editor preferences helps with  this issue. May be related to Bug 323401.

Reproducible: Always
Comment 1 Natalia Bartol CLA 2011-11-28 14:14:09 EST 
Created attachment 207619 [details]
HTML folding in PHP files optimized - patch

Attached patch improves the way the annotation modifications are collected and applied. If annotation projection model change already exists for a node, the old change is removed and only the new one is stored. As a result there is less annotation modifications to apply (applying happens in UI thread and blocks editor).
Comment 2 Zhongwei Zhao CLA 2011-12-01 06:05:20 EST 
it is ok for me,committed.Thanks!
Comment 3 Sylvia Tancheva CLA 2012-07-06 10:01:51 EDT 
Closing
Ilina Stefanova