Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364993 - EJB Client project operation doesn't check supported java version when runtime set
Summary: EJB Client project operation doesn't check supported java version when runtim...
Status: RESOLVED FIXED
Alias: None
Product: WTP EJB Tools
Classification: WebTools
Component: jst.ejb (show other bugs)
Version: 3.3.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.3.1 P   Edit
Assignee: Roberto Sanchez Herrera CLA
QA Contact: Kaloyan Raev CLA
URL:
Whiteboard:
Keywords:
Depends on: 363973 364499
Blocks:
  Show dependency tree
 
Reported: 2011-11-28 13:14 EST by Roberto Sanchez Herrera CLA
Modified: 2011-12-01 15:58 EST (History)
2 users (show)

See Also:
cbridgha: review+

Attachments
Proposed patch (3.46 KB, patch)
2011-11-28 15:19 EST, Roberto Sanchez Herrera CLA 		ccc: iplog+
Details | Diff
Null check for runtime (1.88 KB, patch)
2011-11-30 16:51 EST, Roberto Sanchez Herrera CLA 		ccc: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roberto Sanchez Herrera CLA 2011-11-28 13:14:31 EST 
An adopter is requesting this bug to be fixed in 3.3.1 P

+++ This bug was initially created as a clone of Bug #364499 +++

+++ This bug was initially created as a clone of Bug #363973 +++

Unlike most Faceted project creation operations.  The EJB Client op does not inherit the behavior of synching or reacting to a new runtime set, and checking for the latest java version supported.  This is because it inherits the "default" java version based on the initial fixed facet template.

For instance, if the EJB project version is 3.1, then it defaults to java 6.
Comment 1 Roberto Sanchez Herrera CLA 2011-11-28 15:19:27 EST 
Created attachment 207624 [details]
Proposed patch

Patch created using R3_3_1
Comment 2 Chuck Bridgham CLA 2011-11-28 20:20:59 EST 
same fix reviewed earlier...  I approve
Comment 3 Chuck Bridgham CLA 2011-11-28 20:27:12 EST 
Correction - this was an EJB problem.. properly categorizing
Comment 4 Roberto Sanchez Herrera CLA 2011-11-30 16:51:44 EST 
Created attachment 207763 [details]
Null check for runtime

An NPE was detected when running the JUnits. A null check must be done for the cases where the project does not have runtime. 

Note: This patch does not make obsolete the previous patch:  it should be applied on top of it.
Comment 5 Carl Anderson CLA 2011-12-01 15:58:37 EST 
Committed to R3_3_1_patches