Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364950 - Workbench is not mirrored correctly when using "nl" option
Summary: Workbench is not mirrored correctly when using "nl" option
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 4.2 M7   Edit
Assignee: Oleg Besedin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 352656 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-11-28 08:29 EST by Ghada Selim CLA
Modified: 2012-05-02 03:09 EDT (History)
8 users (show)

See Also:

Attachments
Testing Snapshots (63.18 KB, application/x-rar)
2011-11-28 08:30 EST, Ghada Selim CLA 		no flags Details
Proposed patch (4.07 KB, patch)
2011-11-28 08:33 EST, Ghada Selim CLA 		no flags Details | Diff
Screenshot (76.01 KB, image/png)
2012-05-01 15:21 EDT, Oleg Besedin CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ghada Selim CLA 2011-11-28 08:29:01 EST 
Build Identifier: 

Workbench is not mirrored correctly when using "nl" option with a bidi language pack installed.

Reproducible: Always

Steps to Reproduce:
1.Install Arabic pack.
2.open eclipse with option "-nl ar_eg"

Expected result:
The layout of eclipse workbench is mirrored.(Refer to bug 303889 for a full description for all the the RTL orientation cases against the usage of nl option)

Actual result:
The layout of eclipse workbench is in LTR mode while the internal windows like preference window is mirrored correctly.(See the attachment)
Comment 1 Ghada Selim CLA 2011-11-28 08:30:34 EST 
Created attachment 207600 [details]
Testing Snapshots
Comment 2 Ghada Selim CLA 2011-11-28 08:33:47 EST 
Created attachment 207602 [details]
Proposed patch

Please find a proposed fix for this bug
Comment 3 Oleg Besedin CLA 2012-04-10 14:09:33 EDT 
Thank you Ghada, I added changes to the Git master branch:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7c7397b74eb4af6690d787dd4be9596a2230e555
Comment 4 Oleg Besedin CLA 2012-04-18 11:38:04 EDT 
*** Bug 352656 has been marked as a duplicate of this bug. ***
Comment 5 Oleg Besedin CLA 2012-05-01 14:12:40 EDT 
Verified in I20120430-1800.
Comment 6 Curtis Windatt CLA 2012-05-01 15:10:36 EDT 
I cannot get the workbench to open mirrored.  Perhaps I am getting the steps incorrect.

1) Install the Arabic language pack from Babel
2) Start eclipse I20120410-0633 with -nl ar_eg

The workbench isn't mirrored, the arabic language pack is reasonably complete, so I end up with my workbench looking exactly like the LTR layout from the original picture.  Other dialogs including the preference page/about dialog all show RTL.
Comment 7 Oleg Besedin CLA 2012-05-01 15:21:23 EDT 
Created attachment 214890 [details]
Screenshot

(In reply to comment #6)
> I cannot get the workbench to open mirrored.  Perhaps I am getting the steps
> incorrect.

The attached screenshot is what I see.

> 
> 1) Install the Arabic language pack from Babel
> 2) Start eclipse I20120410-0633 with -nl ar_eg
> 

The "0410"? 

The only thing I can think of is that I put NL packs into drop-in folder.
Comment 8 Dani Megert CLA 2012-05-02 03:09:06 EDT 
I can confirm that it works using 4.2-I20120430-1800. It worked both ways: unzipping into the existing install or into 'dropins'.