Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 364864 - DBWS: need to consolidate duplicate code blocks in OracleHelper
Summary: DBWS: need to consolidate duplicate code blocks in OracleHelper
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-25 13:19 EST by David McCann CLA
Modified: 2022-06-09 10:25 EDT (History)
1 user (show)

See Also:

Attachments
Proposed fix. (42.55 KB, patch)
2011-11-25 14:35 EST, David McCann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David McCann CLA 2011-11-25 13:19:08 EST 
There are a number of places where we create descriptors and mappings for various types (VArray, PL/SQL record, etc) that are identical.  These blocks of code need to be identified and moved into their own methods.
Comment 1 David McCann CLA 2011-11-25 14:35:14 EST 
Created attachment 207555 [details]
Proposed fix.
Comment 2 Mike Norman CLA 2011-11-25 14:39:28 EST 
patch looks good (MWN)
Comment 3 David McCann CLA 2011-11-25 15:01:06 EST 
Reviewed by:  micheal.norman@oracle.com
Tests:  all unit tests pass as expected
Revision: 10467
Comment 4 Eclipse Webmaster CLA 2022-06-09 10:25:12 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink