364855 – feature not correctly built when multiple arch filters are specified

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364855 - feature not correctly built when multiple arch filters are specified

Summary: feature not correctly built when multiple arch filters are specified

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Tycho (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P3 minor (vote)
Target Milestone:	---
Assignee:	Jan Sievers
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:	351056
Blocks:
	Show dependency tree

Reported:	2011-11-25 11:53 EST by Steffen Pingel
Modified:	2021-04-28 16:54 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit

Attachments
example project (61.36 KB, application/octet-stream) 2011-11-25 11:55 EST, Steffen Pingel	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steffen Pingel

2011-11-25 11:53:55 EST

Steps:
1. Build a feature that includes a bundle that has a filter: arch="x86,x86_64"

The build produces a feature.xml that does not correctly include the plugin, e.g.:

   <plugin
         id="example-bundle"
         os="win32"
         ws="win32"
         arch="x86,x86_64"
         download-size="0"
         install-size="0"
         version="0.0.0"
         unpack="false"/>

If I change the filter to arch="x86" the following feature is generated as expected:

   <plugin
         id="example-bundle"
         os="win32"
         ws="win32"
         arch="x86"
         download-size="57"
         install-size="110"
         version="0.1.0.201111251649"
         unpack="false"/>

I am running the build on gtk/X86_64. I have attached a small sample project to reproduce the problem.

Comment 1 Steffen Pingel

2011-11-25 11:55:15 EST

Created attachment 207543 [details]
example project

Comment 2 Steffen Pingel

2011-11-25 11:57:35 EST

This caused the problem described at https://bugs.eclipse.org/bugs/show_bug.cgi?id=349351#c49. The expected bundle with the filter was simply not added to the site. What surprised me is that the build did not fail, neither when the feature was built nor when the repository was generated.

Comment 3 Tobias Oberlies

2012-05-22 10:38:27 EDT

IIRC the syntax with multiple values to os/ws/arch in the inclusion is invalid (see bug 343339 comment 4), so the problem is that the build does not fail.

This probably needs to be fixed in p2, so we'll need the enhancement of p2 bug 351056.

Comment 4 Eclipse Genie

2016-12-07 01:22:08 EST

New Gerrit change created: https://git.eclipse.org/r/86565

Comment 5 Eclipse Genie

2016-12-07 01:22:09 EST

New Gerrit change created: https://git.eclipse.org/r/86565

Comment 6 Jan Sievers

2016-12-12 03:50:29 EST

proposed patch looks promising as it supposedly also fixes bug 392357

Comment 7 Jan Sievers

2016-12-16 11:06:32 EST

(In reply to Jan Sievers from comment #6)
> proposed patch looks promising as it supposedly also fixes bug 392357

I have added a minimal IT to the proposed change.

bug 392357 turns out to be similar but different. It only concerns nl filters (as opposed to os/ws/arch here) and is not fixed by the proposed change

Comment 8 Eclipse Genie

2016-12-19 08:47:22 EST

Gerrit change https://git.eclipse.org/r/86565 was merged to [master].
Commit: http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=0c36eae3b342d9eb33e653f266173c0c3c5771d7

Comment 9 Jan Sievers

2016-12-19 08:48:06 EST